Add an initial "manifest-tool" implementation #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @estesp -- if you've got time to even glance over this, that'd be awesome ❤️ 🙏 👍 |
tianon
commented
Jun 13, 2017
| if err := manifestToolPushFromSpec(tagYaml); err != nil { | ||
| return fmt.Errorf("failed pushing %q (%q)", tag, entry.TagsString()) | ||
| } | ||
| } |
There was a problem hiding this comment.
See estesp/manifest-tool#23 for some discussion of making manifest-tool more efficient for our use case (and thus removing the need for so many nested loops 😇).
7 tasks
|
I've now tested the |
yosifkit
approved these changes
Jun 13, 2017
|
Looks good! I'll work on the tags issue as soon as I can get around to it later this week! |
|
You're a hero; thanks @estesp 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next major milestone towards #2289. This adds manifest list support for our new
Architecturesfields, and technically also forSharedTagsfields, but I haven't tested that support yet (priority ATM isArchitectures-- we'll hit back onSharedTagsafter we getArchitecturesin good shape).See https://hub.docker.com/u/trollin/ for a few repos I've pushed using this. 👍