-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian bookworm, remove buster #1416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except 8.0 that doesn't support OpenSSL 3.x
tianon
reviewed
Jun 13, 2023
@@ -95,6 +96,13 @@ for version in "${versions[@]}"; do | |||
if [ "$rcVersion" = '8.0' ] && [[ "$suite" = alpine* ]] && [ "$suite" != 'alpine3.16' ]; then | |||
continue | |||
fi | |||
# 8.0 doesn't support OpenSSL 3, which is the only version in bookworm | |||
# only keep two variants of Debian per version of php | |||
if [ "$rcVersion" = '8.0' ] && [ "$suite" = 'bookworm' ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I would complain that we're hard-coding bookworm
here in a way that means we'll have to update it again for trixie
but PHP 8.0 should be EOL long before then (later this year!!) 😄
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 13, 2023
Changes: - docker-library/php@86b8b137: Merge pull request docker-library/php#1416 from infosiftr/bookworm - docker-library/php@7838b365: Add Debian bookworm, remove buster - docker-library/php@6fce78bd: enable Max Execution Timers for ZTS builds (docker-library/php#1382)
rybakit
added a commit
to rybakit/msgpack.php
that referenced
this pull request
Jun 18, 2023
The package is not available on recent PHP 8.x images which are based on Debian Bookworm. See docker-library/php#1416.
rybakit
added a commit
to rybakit/msgpack.php
that referenced
this pull request
Jun 18, 2023
The package is not available on recent PHP 8.x images which are based on Debian Bookworm. See docker-library/php#1416.
12 tasks
This was referenced Jun 28, 2023
mlocati
added a commit
to mlocati/docker-php-extension-installer
that referenced
this pull request
Oct 30, 2023
nielsdos
pushed a commit
to nielsdos/docker-php-extension-installer
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except 8.0 that doesn't support OpenSSL 3.x