This repository was archived by the owner on Aug 15, 2018. It is now read-only.
Added support to create virtual network adapters #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test.sh is a simple script that can create and destroy virtual network adapter and add their name in settings.sh
dashohoxha
approved these changes
Jun 16, 2018
There was a problem hiding this comment.
Maybe there are things that need to be fixed or improved. But if you have tested it and it works, you can merge it now.
However the first task for the next week should still be reviewing, improving and fixing the scripts that you have developed so far. It is important that you get testing right because it will make easier your later development phases, and it will make easier for everyone else to follow your development and test your changes.
|
Sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test.shclient.shto grab INTERFACE fromsetting.shVagrantfilefor the samereadme.mdfor instructionscloses #44