This repository was archived by the owner on Aug 15, 2018. It is now read-only.
fixed error in ip address #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now we dont need to halt and up the vagrant box to get gui
apt upgrade now gives interactive gui to get latest version of grub. This is just a temporary fix. Probably fix it in vagrant box v 1.0.3
dashohoxha
reviewed
Jul 11, 2018
There was a problem hiding this comment.
@akash0x53 please review them because I am not able to test them (and I will also be a bit busy on the following days).
akash0x53
reviewed
Jul 11, 2018
| @@ -62,7 +62,7 @@ else | |||
| echo "There is an existing DHCP server running" | |||
| echo "LTSP server won't provide DHCP services.." | |||
| sed -i /etc/dnsmasq.d/ltsp-server-dnsmasq.conf \ | |||
| -e "/192.168.1.0,proxy\$/ c dhcp-range=${NETWORK}.0,proxy" | |||
| -e "/192.168.111.0,proxy\$/ c dhcp-range=${NETWORK}.0,proxy" | |||
There was a problem hiding this comment.
Why 111 and not 222? Is this fixed?
There was a problem hiding this comment.
Yes.
ltsp-config dnsmasq generates the fixed ip address
akash0x53
reviewed
Jul 11, 2018
install.sh
Outdated
| @@ -6,7 +6,7 @@ NETWORK="$(echo $LAN_IP | cut -d'.' -f1-3)" | |||
|
|
|||
| # Updating packages | |||
| apt update --yes | |||
| apt upgrade --yes | |||
| DEBIAN_FRONTEND=noninteractive apt upgrade --yes | |||
There was a problem hiding this comment.
It would be helpful to mention the reason why this variable is set.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default ip set by
ltsp-config dnsmasqis different for linux minttaracloses #63