updated ltsp setup #86

d78ui98 · 2018-07-18T03:20:23Z

I updated virtual ltsp server to install latest packages for ltsp
Used auto_config option of in vagrantfile
closes Update virtual LTSP server project to new version of LTSP #85 Configure dns to provide internet to clients #83

we dont need to add repository again so shifted ltsp-manager with other packages

d78ui98 · 2018-07-18T03:24:11Z

These commits were done hours ago. I was trying to fix the test.sh script. In case of normal mode the vagrant box(ltsp server) server does not get ip address from the dhcp server. As a result the script fails in nornal mode.

akash0x53 · 2018-07-18T03:36:42Z

Vagrantfile

@@ -6,7 +6,11 @@ Vagrant.configure("2") do |config|

  config.vm.box = VB_IMAGE

-  config.vm.network "public_network", ip: LAN_IP, netmask: "255.255.255.0", bridge: LAN_IF
+  if $STANDALONE == "yes"		


when comparing string always convert the case.

akash0x53 · 2018-07-18T03:44:23Z

install.sh

+
+# Fetching LAN_IP and network address
+if [[ ${STANDALONE,,} != yes ]]; then
+   LAN_IP=$(ip addr | grep "inet\b" | cut -d" " -f6 | grep 192 |  cut -d/ -f1)


You assumed LAN_IP will always class C 192.168.yyy.zzz. One can set 172.xxx.yyy.zzz

try
ip addr show <interface> | grep -Po 'inet \K[\d.]+'

I am not sure if the interface name would be same everytime. Hardcoding interface does not seem like a good idea.
nice regex by the way :)

Yes, interface is the same every time, and it is LAN_IF.
The code proposed by Akash is correct

Using this is also a good idea I think. Bcoz bridged interface will be always on 3 position.
ip addr | grep -Po -m3 'inet \K[\d.]+' | tail -n1
Let me know what are your thoughts on this.

No, it is not a good idea, because it never guarantied that the order of the interfaces will be the same. Do as Akash and me suggested: ip addr show $LAN_IF

Yes. you are right.

dashohoxha · 2018-07-18T11:49:09Z

install.sh

+if [[ ${STANDALONE,,} != yes ]]; then
+   LAN_IP=$(ip addr | grep "inet\b" | cut -d" " -f6 | grep 192 |  cut -d/ -f1)
+   sed -i /vagrant/settings.sh \
+      -e "/LAN_IP=""/ c LAN_IP=\"$LAN_IP\""


It is not a good idea to modify settings.sh from install.sh.
I also don't think you need to do that.

removed lines to modify settings.sh

akash0x53 · 2018-07-18T12:14:44Z

install.sh

+
+# Fetching LAN_IP and network address
+if [[ ${STANDALONE,,} != yes ]]; then
+   LAN_IP=$(ip addr | grep -Po -m3 'inet \K[\d.]+' | tail -n1)


network interfaces at my end

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever 2: enp0s3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000 link/ether 08:00:27:af:06:9a brd ff:ff:ff:ff:ff:ff inet 10.0.2.15/24 brd 10.0.2.255 scope global dynamic enp0s3 valid_lft 85960sec preferred_lft 85960sec inet6 fe80::bc9e:d02b:c104:fcef/64 scope link valid_lft forever preferred_lft forever 3: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default link/ether 02:42:68:9b:93:36 brd ff:ff:ff:ff:ff:ff inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0 valid_lft forever preferred_lft forever

above command gives me dockers ip address, which is not what we need.

Check if these snippet helps you. This will not require interface name, no grep, no assumption.

akash@skyfall:$ ip route get 8.8.8.8 8.8.8.8 via 10.0.2.2 dev enp0s3 src 10.0.2.15 cache akash@skyfall:$ ip route get 8.8.8.8|head -n1|cut -d ' ' -f8

above command gives me dockers ip address, which is not what we need.

Akash, Deepanshu was assuming that the command was executed inside the VB machine, not on the host. It seems that you are trying the command on the host.

ip route get 8.8.8.8

This does not work for the case of STANDALONE, because it will give the WAN_IP, not the LAN_IP. (By the way, ip route | grep default is better than this, when we need to get the WAN_IP).

Right, i ran command on my host machine. ip route | grep default is also good option to avoid hardcoding interface name here.

This looks like ip addr output of host machine.(because of docker0)
In vagrant box also first is lo, second is enp0s3, third is enp0s8(bridged adapter the one we need)

is also good option to avoid hardcoding interface name here.

Yes I was also trying to do the same. See my thoughts were. when we do a vagrant up. network adapters are created. Output is something like this -

==> default: Preparing network interfaces based on configuration... default: Adapter 1: nat default: Adapter 2: bridged

So I thought network adapter will always be created in this ordered mentioned.

Yes, interface is the same every time, and it is LAN_IF.
The code proposed by Akash is correct

So should we merge this?

akash0x53 · 2018-07-19T17:22:56Z

install.sh

+
+# Fetching LAN_IP and network address
+if [[ ${STANDALONE,,} != yes ]]; then
+   LAN_IP=$(ip addr show enp0s8 | grep -Po 'inet \K[\d.]+')


Seems okay to use interface for now.

d78ui98 added 6 commits July 18, 2018 08:07

added autoconfig to Vagrantfile

d798157

fetching ip and network address

ceff5bc

updating packages

2f0b974

removing old dnsmasq and resolvconf setting

64b4671

fixing default ip range

69759df

we dont need to add repository again so shifted ltsp-manager with other packages

updated settings.sh

2b1d1e7

akash0x53 reviewed Jul 18, 2018

View reviewed changes

d78ui98 added 2 commits July 18, 2018 14:34

string to downcase

b79e51d

implemented regex for fetching ip address

9b81f99

dashohoxha reviewed Jul 18, 2018

View reviewed changes

updated install.sh

8764d34

removed lines to modify settings.sh

akash0x53 reviewed Jul 18, 2018

View reviewed changes

updated code to fetch ip address

c67c401

akash0x53 approved these changes Jul 19, 2018

View reviewed changes

d78ui98 merged commit 4efa9ca into bionic Jul 19, 2018

d78ui98 deleted the new-ltsp branch July 19, 2018 18:04

updated ltsp setup #86

updated ltsp setup #86

Uh oh!

Conversation

d78ui98 commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

d78ui98 commented Jul 18, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akash0x53 Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d78ui98 Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d78ui98 Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d78ui98 Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

d78ui98 commented Jul 18, 2018 •

edited

Loading

akash0x53 Jul 18, 2018 •

edited

Loading

d78ui98 Jul 18, 2018 •

edited

Loading

d78ui98 Jul 18, 2018 •

edited

Loading

d78ui98 Jul 18, 2018 •

edited

Loading