Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Use app naming rules in error and progress messages #713

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

carolinebriaud
Copy link
Contributor

Signed-off-by: Caroline Briaud caroline.briaud@docker.com

- What I did
Use App naming rules for error and progress messages

- How to verify it
Go through error messages and progress messages

- A picture of a cute animal (not mandatory but encouraged)
IMG_7603

Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
@silvin-lubecki
Copy link
Contributor

=== Failed
=== FAIL: e2e TestPushPullInstall (16.76s)
    pushpull_test.go:185: assertion failed: 
        Command:  docker app run unknown
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Pulling from registry...
        Stderr:   Unable to find application image "unknown:latest" locally
        Unable to find App "unknown": failed to resolve bundle manifest "docker.io/library/unknown:latest": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
        Failures:
        Expected stderr to contain "Unable to find application image \"unknown:latest\" locally\nUnable to find application \"unknown\": failed to resolve bundle manifest \"docker.io/library/unknown:latest\": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed"

Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files          59       59           
  Lines        3051     3051           
=======================================
  Hits         2184     2184           
  Misses        585      585           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e215e7...0abe6b4. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 0ffdc18 into docker:master Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants