Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Add note to enable BuildKit to build in docker #729

Merged

Conversation

zappy-shu
Copy link
Contributor

- What I did

Adds a note in the "Build using Docker" section of BUILDING.md to explain that BuildKit is required and how to enable it.

- A picture of a cute animal (not mandatory)

hedgehog-2019-11-07

Adds a note in the "Build using Docker" section of BUILDING.md to
explain that BuildKit is required and how to enable it.

Signed-off-by: Nick Adcock <nick.adcock@docker.com>
@ndeloof
Copy link
Contributor

ndeloof commented Nov 7, 2019

@zappy-shu build failed by jenkins internal issue, can your please git ci --amend your last commit and force push to trigger a fresh new build ?

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #729 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   70.94%   71.54%   +0.59%     
==========================================
  Files          61       60       -1     
  Lines        3493     3201     -292     
==========================================
- Hits         2478     2290     -188     
+ Misses        695      603      -92     
+ Partials      320      308      -12
Impacted Files Coverage Δ
internal/packager/init.go 61.68% <0%> (-9.13%) ⬇️
internal/commands/root.go 73.86% <0%> (-4.65%) ⬇️
internal/packager/cnab.go 97.91% <0%> (-0.09%) ⬇️
internal/names.go 100% <0%> (ø) ⬆️
internal/commands/inspect.go
types/parameters/parameters.go 93.65% <0%> (+1.58%) ⬆️
internal/inspect/inspect.go 86.88% <0%> (+8.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acd0a8...bdbcf4d. Read the comment docs.

@zappy-shu zappy-shu merged commit bff05c3 into docker:master Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants