This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Only push applications from the local store #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
- Coverage 70.1% 70.02% -0.08%
==========================================
Files 62 62
Lines 3318 3213 -105
==========================================
- Hits 2326 2250 -76
+ Misses 682 660 -22
+ Partials 310 303 -7
Continue to review full report at Codecov.
|
`cnab.ResolveBundle` would try the local store first and pull if the app is not found. This is not what we want when we push. We only want to push local applications. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Making sure that the errors are well defined. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-push-local-store
branch
from
0c85129
to
1fd4785
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
cnab.ResolveBundlewould try the local store first and pull if the appis not found. This is not what we want when we push. We only want to
push local applications.
- A picture of a cute animal (not mandatory)
