Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Check compose file don't use relative paths for bind mount #742

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 13, 2019

- What I did
Reject compose file to use a relative path for bind mount
https://docker.atlassian.net/browse/APP-275

- How I did it

  • checked yaml tree during init
  • added volumes to partial mapping used by build and check source path

- How to verify it

  • use a compose file with relative path bind mount and run docker app init
  • use a docker.app and edit compose file to introduce relative path bind mount, then run docker app build

- Description for the changelog
Docker app do reject compose file relying on a relative volume path

- A picture of a cute animal (not mandatory)
image

internal/commands/build/types.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #742 into master will increase coverage by <.01%.
The diff coverage is 71.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   68.97%   68.98%   +<.01%     
==========================================
  Files          64       63       -1     
  Lines        3439     3440       +1     
==========================================
+ Hits         2372     2373       +1     
  Misses        749      749              
  Partials      318      318
Impacted Files Coverage Δ
internal/commands/build/build.go 60.4% <66.66%> (ø) ⬆️
internal/packager/init.go 64.64% <70.58%> (+1.37%) ⬆️
internal/commands/build/compose.go 78.57% <73.33%> (-5.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b339e0b...0372f49. Read the comment docs.

Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants