This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Introduce --force option on image rm command
#762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
force
branch
2 times, most recently
from
2678e09
to
d551834
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
eunomie
reviewed
Nov 26, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
eunomie
approved these changes
Nov 26, 2019
rumpl
reviewed
Nov 26, 2019
| } | ||
| } | ||
| return failures.ErrorOrNil() | ||
| } | ||
| return fmt.Errorf("unable to delete %q - App is referenced in multiple repositories", reference.FamiliarString(ref)) |
There was a problem hiding this comment.
Should we say here something like ", can be forced (-f)" ?
There was a problem hiding this comment.
docker image CLI for equivalent scenario:
conflict: unable to delete xyz (must be forced) - image is referenced in multiple repositories
There was a problem hiding this comment.
I'll address this in a subsequent PR with bundlestore refactoring
|
What does the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added
--forceoption ondocker app image rmcommand- How I did it
Bundlestore do check all reference for ID to remove, and delete them
Also introduced bundle store cleanup by removing empty paths as a tag is deleted
- How to verify it
docker app build -t foo (get built image ID)
docker app tag foo bar
docker app image rm {ID} // will fail
docker app image rm --force {ID} // won't fail
docker app image ls
- Description for the changelog
Added
--forceoption ondocker app image rmcommand- A picture of a cute animal (not mandatory)