This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Create a context for the progress printer #764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call cancel on the context once we finished so that it will stop printing stuff. This *could* fix APP-349 and could fix the errors with status code 141 that we see on our CI. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
- Coverage 71.27% 69.52% -1.76%
==========================================
Files 67 64 -3
Lines 3837 3521 -316
==========================================
- Hits 2735 2448 -287
+ Misses 768 753 -15
+ Partials 334 320 -14
Continue to review full report at Codecov.
|
| @@ -169,7 +169,9 @@ func buildImageUsingBuildx(app *types.App, contextPath string, opt buildOptions, | |||
| out = os.NewFile(dockerCli.Out().FD(), "/dev/stdout") | |||
| } | |||
|
|
|||
| pw := progress.NewPrinter(ctx, out, opt.progress) | |||
| ctx2, cancel := context.WithCancel(context.TODO()) | |||
There was a problem hiding this comment.
I think a regression test could be tricky to add here, but maybe a one line comment explaining why we have another context?
There was a problem hiding this comment.
maybe we can find a better name, like printerContext?
Suggested change
| ctx2, cancel := context.WithCancel(context.TODO()) | |
| printerContext, cancel := context.WithCancel(context.TODO()) |
silvin-lubecki
approved these changes
Nov 25, 2019
eunomie
reviewed
Nov 26, 2019
| @@ -169,7 +169,9 @@ func buildImageUsingBuildx(app *types.App, contextPath string, opt buildOptions, | |||
| out = os.NewFile(dockerCli.Out().FD(), "/dev/stdout") | |||
| } | |||
|
|
|||
| pw := progress.NewPrinter(ctx, out, opt.progress) | |||
| ctx2, cancel := context.WithCancel(context.TODO()) | |||
There was a problem hiding this comment.
maybe we can find a better name, like printerContext?
Suggested change
| ctx2, cancel := context.WithCancel(context.TODO()) | |
| printerContext, cancel := context.WithCancel(context.TODO()) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call cancel on the context once we finished so that it will stop
printing stuff. This could fix APP-349 and could fix the errors with
status code 141 that we see on our CI.