This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Update cnab-to-oci to v0.3.0-beta2 #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates vendor of cnab-to-oci to v0.3.0-beta2: * Push images using relocation map first, then from the bundle * Fix Docker CLI authentication to registries for the push * Simplify error message returned when pulling CNAB bundle that is not found Signed-off-by: Nick Adcock <nick.adcock@docker.com>
rumpl
approved these changes
Nov 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 69.66% 69.55% -0.12%
==========================================
Files 64 64
Lines 3597 3567 -30
==========================================
- Hits 2506 2481 -25
+ Misses 760 758 -2
+ Partials 331 328 -3
Continue to review full report at Codecov.
|
|
I think we can close it as the bump as been done in #748 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updates vendor of cnab-to-oci to v0.3.0-beta2:
- How to verify it
Attempt to pull an app that does not exist. E.g.
docker app pull carolinebriaud/vappThe error message should now be simplified to:
carolinebriaud/vapp: docker.io/carolinebriaud/vapp:latest: not found- Description for the changelog
Simplify error message returned when pulling CNAB bundle that is not found
- A picture of a cute animal (not mandatory)