Rename relocated.bundle to AppImage #773
Conversation
| } | ||
|
|
||
| func getRelocatedBundle() (*relocated.Bundle, error) { | ||
| func getRelocatedBundle() (*image.AppImage, error) { |
There was a problem hiding this comment.
super nit: What about image.App ? image.AppImage sounds like repetition
There was a problem hiding this comment.
Better rename package then. "App" is highly confusing with "running app".
| "github.com/docker/distribution/reference" | ||
| multierror "github.com/hashicorp/go-multierror" | ||
| digest "github.com/opencontainers/go-digest" | ||
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| // | ||
| type BundleStore interface { | ||
| type ImageStore interface { |
There was a problem hiding this comment.
super nit: Is it an ImageStore or an AppImageStore ?
There was a problem hiding this comment.
I was also wondering. wanted to avoid too long names (hey, this is Golang :P) but AppImageStore would better describe
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 70.4% 70.32% -0.09%
==========================================
Files 67 67
Lines 3740 3740
==========================================
- Hits 2633 2630 -3
- Misses 760 762 +2
- Partials 347 348 +1
Continue to review full report at Codecov.
|
ndeloof
force-pushed
the
imageStore
branch
2 times, most recently
from
f90e584
to
1cdacc0
Compare
also rename bundleStore to imagestore and variables pointing to relocated.bundles to `img` Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
- What I did
Renamed relocated.bundle to AppImage
bundleStore to ImageStore
bndl variables to img
- How I did it
asked my IDE to do the job for me
- How to verify it
You don't read code using a
bundlethat is more than just a cnab bundle.- Description for the changelog
Introduced AppImage type and ImageStore
- A picture of a cute animal (not mandatory)
