Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

WIP - Add distributed claim store through Kubernetes' secrets #794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ulyssessouza
Copy link
Contributor

- What I did
Implement distrubuted claim store for installations targeting kubernetes (with compose-on-kubernetes)

- How I did it
Just detect a kubernetes target by the context. If k8s, then use secrets as store for in a dedicated namespace (called docker-app)

- How to verify it
Create a new docker context pointing to a kuberneted with compose-on-kubernetes installed then install an app. Check in the dashboard that a new namespace called docker-app was created and that the corresponding secret has also been created.

- Description for the changelog
Add kubernetes as a claim store.

- A picture of a cute animal (not mandatory)
distributed-goats

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #794 into master will decrease coverage by 2%.
The diff coverage is 14.81%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #794    +/-   ##
========================================
- Coverage   70.03%   68.03%    -2%     
========================================
  Files          67       69     +2     
  Lines        3684     3807   +123     
========================================
+ Hits         2580     2590    +10     
- Misses        759      867   +108     
- Partials      345      350     +5
Impacted Files Coverage Δ
internal/store/installation.go 78.12% <ø> (ø) ⬆️
internal/store/crud/kubernetes.go 0% <0%> (ø)
internal/commands/root.go 60% <100%> (ø) ⬆️
internal/store/utils.go 100% <100%> (ø)
internal/store/app.go 57.14% <29.41%> (-16.2%) ⬇️
internal/commands/run.go 61.45% <50%> (-0.91%) ⬇️
internal/commands/update.go 55.73% <50%> (-1.16%) ⬇️
internal/commands/list.go 75.96% <50%> (-1.02%) ⬇️
internal/commands/inspect.go 47.69% <50%> (-0.7%) ⬇️
internal/commands/remove.go 49.15% <50%> (-0.85%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d698be...780f3d7. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants