-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to yarn 3.6.3 #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is yarn itself committed to the repository? We don't even store the modules we use in the repo.
Yarn Modern (v2/v3) has some breaking changes with old v1 and therefore requires Yarn releases to be kept versioned: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored. This prevents potential issues if, say, two engineers use different Yarn versions with different features. |
9f553cb
to
3130840
Compare
@tonistiigi Setting yarn version in the Dockerfile works: master...crazy-max:docker-bake-action:yarn-update-2#diff-3ed65642ec1610de6b0f162c77dc8499662ebeb7057d3f6c89108952d1cb33deR10-R14 but Dependabot will still use Yarn v1 and corrupt the lock file 😞. Unfortunately we can't define yarn version in the yarnrc config, just the yarnPath: https://yarnpkg.com/configuration/yarnrc#yarnPath
|
@tonistiigi Switching back to npm looks to be the only alternative we have if you still don't want yarn installed within the repo: |
@tonistiigi Now using corepack to avoid having yarn in the repo. |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
closes #102
update to Yarn 3.6.3 now that Dependabot supports Yarn v2/v3: dependabot/dependabot-core#1297 (comment)
For migration steps see https://yarnpkg.com/getting-started/migration
Also use corepack similar to docker/actions-toolkit#323 to download yarn on-fly.
Also install plugin-interactive-tools yarn pkg: https://yarnpkg.com/api/modules/plugin_interactive_tools.html