-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update --load with a note highlight #1221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand that the first part of this comment is trying to say. And push is documented separately. If there is a note, it should just say that docker load
command currently does not support loading multi-platform images so only a single platform can be specified for such builds.
That's fair. The part in question:
From my point of view and understanding, I assume that
I felt that mentioning that, before explaining the |
Looking at https://github.com/docker/buildx/blob/e12827910c278b76b9bb1050e7157354db3b1f42/docs/reference/buildx_build.md#docker the multi-platform case is already described there. And it is linked from |
Ohhh alright!
I looked at your linked resource, which mentions:
The "registry" this part links to mentions:
Looking a bit further, the Push the build result to a registry (--push) mentions:
As a reader, I get a feeling that there are now 3 ways to push to the registry in order to use multi-platform:
While I believe they all use the underlying process, it still confuses me as a reader. Here are my propositions, then:
|
Some related discussion on that in docker/cli#3676 (comment) |
I don't really understand these.
This is already documented. If you think you can improve its readability, go ahead, and we will check.
Load should not document push options. Push should document push options.
Don't understand what you mean here. |
Closing this due to inactivity - @larsqa, if you want to re-open, please go ahead! 🎉 |
Proposal after discussion of #1220
Single platform for the
--load
option should be more highlighted, with the help of a Note?