-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bake: initial implementation #16
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Looks good, but why HCL? |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda I don't really care about the format that much. Could accept anything that we can parse. You can use JSON as well (and thinking if we should allow json5). Examples use HCL cause I personally found it more readable and better than toml on comparisons. I'm not a big fan of yaml but the main thing is that I'd want to avoid something that looks like compose but isn't compose. Atm. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
updated buildkit to bring in moby/buildkit#929 |
return ParseHCL(dt) | ||
} | ||
|
||
cfg, err := ParseCompose(dt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there compose files without .yml
or .yaml
suffixes? Why not error out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. Does compose force you to use .yml
suffix currently, I think not.
Tags: t.Tags, | ||
BuildArgs: t.Args, | ||
Labels: t.Labels, | ||
// CacheFrom: t.CacheFrom, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key does not exist atm. but should later.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@tonistiigi what ever happened to |
@FernandoMiguel wdym? |
@tonistiigi in the OP example I'm trying to pass args to my buildx |
Initial implementation for #13 (formely buildfile)
Testing:
The compose part is pretty basic and should work as expected. The full internal datastructure for defining targets probably needs some design work and doesn't look right to me.
Alternative designs:
Outputs not supported yet, thinking if this should be per target or global.
@tiborvass @AkihiroSuda @seemethere @dmcgowan