vendor: update buildkit to master #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: test failures will be due to #2023 (comment), we need to update to point to the image built from Line 9 in da66629 |
crazy-max
reviewed
Sep 7, 2023
jedevc
force-pushed
the
update-buildkit
branch
3 times, most recently
from
86aae63
to
951a642
Compare
crazy-max
reviewed
Sep 8, 2023
crazy-max
approved these changes
Sep 8, 2023
tonistiigi
reviewed
Sep 12, 2023
This was referenced Sep 26, 2023
jedevc
force-pushed
the
update-buildkit
branch
from
65a5c8e
to
b9aad03
Compare
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Without this, we attempt to overwrite the previous display in the lines above which have been filled with logs from the monitor (see when used with `--invoke`). Signed-off-by: Justin Chadwell <me@jedevc.com>
crazy-max
approved these changes
Sep 27, 2023
|
@dvdksn https://docs.docker.com/engine/reference/commandline/buildx_build/#progress looks outdated and should include new raw json mode: https://github.com/moby/buildkit/blob/c8b64d3d83fa7d0e9d5d4ab500df9d4cfe0e8b6d/util/progress/progressui/display.go#L135-L137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Buildkit to the latest master commit (replaces #2023)
This pulls in relevant upstream changes such as:
client.Waitbackoffs moby/buildkit#4200client.Waitmethod to bootstrap for remote driver #1934, which fixes the equivalent regression from After upgrade local CLI to 0.12 remote build stop working moby/buildkit#4164 in the remote driverrawjson.quiet- since the logic for parsing display modes has been moved into theprogressui.NewDisplay, we need an upstream patch progress: add new quiet display mode moby/buildkit#4213 to add this display mode back in. This is actually good - having different sets of display modes between buildx and buildkit was confusing.