Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't generate metadata file when print flag is used #2422

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Apr 19, 2024

related to #2416, we should not generate metadata file when print flag is used

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just skip the --metadata-file ?

@crazy-max
Copy link
Member Author

crazy-max commented Apr 25, 2024

Shouldn't we just skip the --metadata-file ?

Yes good point we should do this as well.

Edit: Added extra commit to not write metadata file if print is used.

build/build.go Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title build: don't set build record provenance for internal build build: don't generate metadata file when print flag is used Apr 26, 2024
@tonistiigi tonistiigi merged commit 1fb5d2a into docker:master Apr 30, 2024
86 checks passed
@crazy-max crazy-max deleted the skip-provenance-internal branch April 30, 2024 06:37
@crazy-max crazy-max modified the milestones: v0.14.1, v0.15.0 May 16, 2024
@thompson-shaun thompson-shaun added the kind/bug Something isn't working label May 16, 2024
@thompson-shaun thompson-shaun modified the milestones: v0.15.0, v0.14.1 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants