Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label filter for docker system prune ignored by non-recent Docker hosts #17

Closed
aduermael opened this issue May 2, 2017 · 1 comment
Closed

label filter for docker system prune ignored by non-recent Docker hosts #17

aduermael opened this issue May 2, 2017 · 1 comment
Milestone
17.06.0

Comments

@aduermael
Copy link
Contributor

aduermael commented May 2, 2017 •
edited
Loading

label filter for docker system prune (and others like docker container prune) has been added in that commit: moby/moby@7025247

But using it targeting non-recent Docker hosts may be dangerous has this filter is not even considered.

It leads to situations like this one:

$ docker create --label foo=bar redis
5fb69165f8069420f34117c7ec1bc62b55c56cf1f9d9c148188bab1814b3d859
$ docker container prune --filter label=foo=nope
WARNING! This will remove all stopped containers.
Are you sure you want to continue? [y/N] y
Deleted Containers:
5fb69165f8069420f34117c7ec1bc62b55c56cf1f9d9c148188bab1814b3d859

The CLI should display return an error when using that filter if remote API version to 1.29.
@aduermael aduermael mentioned this issue May 2, 2017
Merged
@thaJeztah thaJeztah added this to the 17.06.0 milestone May 17, 2017
@thomassuckow
Copy link

thomassuckow commented Jan 25, 2018 •
edited
Loading

Just updated to docker for mac 17.12.0-ce-mac49 and got bit by this.

Seems like if a filter option is provided that isn't understood by the engine it should be fatal and would prevent these kinds of issues in the future if more filter options are provided.

Edit: Which doesn't make sense anyway since it is supposed to be API 1.35

chris-crone pushed a commit to chris-crone/cli that referenced this issue Jun 11, 2018
@mavenugo
Merge pull request docker#17 from thaJeztah/18.03-backport-hide_check…
c41b3cd 
…point_on_windows

[18.03-ee] backport Hide experimental checkpoint features on Windows
thaJeztah added a commit to thaJeztah/cli that referenced this issue Sep 26, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
4727900 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Sep 26, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
2d1e8b7 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Sep 26, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
64b52e9 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Sep 26, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
a2c6283 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Sep 26, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
8b29d34 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Nov 23, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
1737f30 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Nov 23, 2023
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
6a74a63 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Jan 10, 2024
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
c2d3006 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 6a74a63)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Jan 24, 2024
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
fd21841 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 6a74a63)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Jan 24, 2024
@thaJeztah
Dockerfile: update ALPINE_VERSION to 3.18
71c12cf 
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 6a74a63)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.06.0
Development

No branches or pull requests
4 participants
@vdemeester @thaJeztah @thomassuckow @aduermael