Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckRedirect for GO 1.8 #64

Closed
dnephin opened this issue May 10, 2017 · 5 comments
Closed

Add CheckRedirect for GO 1.8 #64

dnephin opened this issue May 10, 2017 · 5 comments
Milestone

Comments

@dnephin
Copy link
Contributor

dnephin commented May 10, 2017

We need to make sure that we get the fix from moby/moby#32127 if we want to build the client with GO 1.8.

The changes in that PR will not affect the cli because a client is created in cli/command/cli.go, so we need to use the CheckRedirect function from that PR where we create the client.

@dnephin
Copy link
Contributor Author

dnephin commented May 11, 2017

The referenced PR was merged so we can now make this change.

@boaz0
Copy link
Contributor

boaz0 commented May 11, 2017

@dnephin does that make sense if I call #dibs on that?

@dnephin
Copy link
Contributor Author

dnephin commented May 11, 2017

That would be great, thank you!

@boaz0
Copy link
Contributor

boaz0 commented May 15, 2017

@dnephin it seems like moby/moby#32127 was added in #45 so I think we can close this.

I built this on my computer and CheckRedirect works.

@dnephin
Copy link
Contributor Author

dnephin commented May 16, 2017

This repo doesn't use the code from moby/moby to create an http.Client. I'll open a PR, it should be small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants