-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CheckRedirect for GO 1.8 #64
Milestone
Comments
The referenced PR was merged so we can now make this change. |
@dnephin does that make sense if I call #dibs on that? |
That would be great, thank you! |
@dnephin it seems like moby/moby#32127 was added in #45 so I think we can close this. I built this on my computer and |
This repo doesn't use the code from moby/moby to create an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to make sure that we get the fix from moby/moby#32127 if we want to build the client with GO 1.8.
The changes in that PR will not affect the cli because a client is created in
cli/command/cli.go
, so we need to use theCheckRedirect
function from that PR where we create the client.The text was updated successfully, but these errors were encountered: