Bump Golang to 1.10.3 #1122
Bump Golang to 1.10.3 #1122
Conversation
|
Waiting for docker/golang-cross#7 to be built on Docker Hub |
thaJeztah
added
impact/changelog
status/2-code-review
and removed
status/0-triage
labels
thaJeztah
force-pushed
the
bump_golang_1.10.3
branch
from
1dc1694
to
58146a3
Compare
|
Ok, this is ready now; ping @vdemeester @silvin-lubecki @dnephin PTAL |
go1.10.3 (released 2018/06/05) includes fixes to the go command, and the crypto/tls, crypto/x509, and strings packages. In particular, it adds minimal support to the go command for the vgo transition. See the Go 1.10.3 milestone on our issue tracker for details; https://github.com/golang/go/issues?q=milestone%3AGo1.10.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_golang_1.10.3
branch
from
58146a3
to
1c71c95
Compare
|
Updated appveyor.yml as well (thanks @chris-crone !) |
|
ping @vdemeester looks like appveyor isn't actually run; it was added in #905, but maybe never configured? |
There was a problem hiding this comment.
LGTM!
It appears the appveyor.yml is not being used so we should consider removing it in a followup cc @vdemeester
|
Or preferably, wiring it up, I guess #905 |
There was a problem hiding this comment.
LGTM
Should we also change
cli/cli/command/system/version_test.go
Line 55 in 4cb3c70
|
Don't think the test needs updating, but we could replace it with some fictive version to make it more clear it's just for testing |
|
Don't know if I have time to do so right now, so if it's ok for a follow up 😄 |
+1 on this but in a followup |
go1.10.3 (released 2018/06/05) includes fixes to the go command, and the
crypto/tls, crypto/x509, and strings packages. In particular, it adds minimal
support to the go command for the vgo transition. See the Go 1.10.3 milestone
on our issue tracker for details;
https://github.com/golang/go/issues?q=milestone%3AGo1.10.3