Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bash completion for builder prune #1727

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Add bash completion for builder prune #1727

merged 1 commit into from
Mar 21, 2019

Conversation

albers
Copy link
Collaborator

@albers albers commented Mar 9, 2019

Bash completion for #1295

@albers
Add bash completion for builder prune
24ca6cc 
Signed-off-by: Harald Albers <github@albersweb.de>
@albers albers changed the title [WIP] Add bash completion for builder prune Add bash completion for builder prune Mar 10, 2019
@albers albers requested a review from thaJeztah March 10, 2019 13:27
thaJeztah
thaJeztah approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ping @tiborvass @silvin-lubecki @tonistiigi

@silvin-lubecki
Copy link
Contributor

The build failed weirdly, I re-run it.

silvin-lubecki
silvin-lubecki approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the build.

@thaJeztah
Copy link
Member

failure is unrelated, and should be fixed in master

10:19:26 Creating mailbox file: No such file or directory
10:19:27 Password: chsh: PAM: Authentication token manipulation error

@thaJeztah thaJeztah merged commit 93f34dc into docker:master Mar 21, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Mar 21, 2019
@albers albers deleted the completion-builder-prune branch March 21, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/builder area/completion status/2-code-review
Projects
None yet
Milestone
19.03.0
Development

Successfully merging this pull request may close these issues.
4 participants
@albers @silvin-lubecki @thaJeztah @GordonTheTurtle