Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash completion for docker context command family #1619

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Bash completion for docker context command family #1619

merged 2 commits into from
Jan 29, 2019

Conversation

albers
Copy link
Collaborator

@albers albers commented Jan 17, 2019

Ref: #1501

@codecov-io
Copy link

Codecov Report

Merging #1619 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1619   +/-   ##
=======================================
  Coverage   55.16%   55.16%           
=======================================
  Files         301      301           
  Lines       20384    20384           
=======================================
  Hits        11244    11244           
  Misses       8335     8335           
  Partials      805      805

@andrewhsu andrewhsu mentioned this pull request Jan 18, 2019
Closed
5 tasks
@albers
Add bash completion for the context command family
41bd8da 
Signed-off-by: Harald Albers <github@albersweb.de>
@docker docker deleted a comment from GordonTheTurtle Jan 20, 2019
@albers albers changed the title WIP: Bash completion for docker context command family Bash completion for docker context command family Jan 20, 2019
@albers albers added this to the 19.03.0 milestone Jan 20, 2019
simonferquel
simonferquel reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@simonferquel simonferquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also note the --context (or -c) global flag. It should have a similar impact as --host on other completion scripts (list of containers, images etc.)
Otherwise seems good to me :)

@albers
Add bash completion for global --context|-c option
884d078 
Signed-off-by: Harald Albers <github@albersweb.de>
@albers
Copy link
Collaborator Author

albers commented Jan 22, 2019

@simonferquel Done.

  • Added completion for the global --context option.
  • If --context is present, its value will be passed on to all docker invocations done by the completion script (like --host).

@simonferquel
Copy link
Contributor

That seems good, I can't test it right now though :/ ping @vdemeester or @thaJeztah

silvin-lubecki
silvin-lubecki approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a shell completion expert at all, but as far as I can tell, it looks good to me 👍

vdemeester
vdemeester approved these changes Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯
/cc @thaJeztah

thaJeztah
thaJeztah approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit a3a30fa into docker:master Jan 29, 2019
@albers albers deleted the completion-context branch January 29, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonferquel simonferquel simonferquel left review comments

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/completion area/context status/2-code-review
Projects
None yet
Milestone
19.03.0
Development

Successfully merging this pull request may close these issues.
7 participants
@albers @codecov-io @simonferquel @vdemeester @thaJeztah @silvin-lubecki @GordonTheTurtle