compose file: disallow additional properties in credential_spec #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
compose_credential_spec_fix
branch
from
980bac8
to
eb3998b
Compare
thaJeztah
commented
Feb 2, 2019
| @@ -283,7 +283,7 @@ services: | |||
| foo: | |||
| image: busybox | |||
| credential_spec: | |||
| File: "/foo" | |||
| file: "/foo" | |||
There was a problem hiding this comment.
looks like this test was incorrect? Or is there a way to make these case-insensitive?
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
compose_credential_spec_fix
branch
from
eb3998b
to
1e99ed3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
+ Coverage 56.11% 56.13% +0.01%
==========================================
Files 306 306
Lines 20909 20909
==========================================
+ Hits 11734 11737 +3
+ Misses 8328 8325 -3
Partials 847 847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @vdemeester @silvin-lubecki PTAL