Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 to manifest annotation and bash completion #2084

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Add riscv64 to manifest annotation and bash completion #2084

merged 1 commit into from
Sep 13, 2019

Conversation

carlosedp
Copy link
Contributor

Signed-off-by: Carlos de Paula me@carlosedp.com

- What I did

Added riscv64 architecture to manifest annotation and bash completion.

- How I did it

Added to architecture list.

- Verify

With updated docker cli, images are correctly tagged and pushed:

image

- Description for the changelog

Add riscv64 architecture to manifest annotation and bash completion.

- A picture of a cute animal (not mandatory but encouraged)

image

@codecov-io
Copy link

Codecov Report

Merging #2084 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2084   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files         311      311           
  Lines       21839    21839           
=======================================
  Hits        12402    12402           
  Misses       8522     8522           
  Partials      915      915

Signed-off-by: Carlos de Paula <me@carlosedp.com>
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@tonistiigi tonistiigi merged commit 95327f4 into docker:master Sep 13, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Sep 13, 2019
@carlosedp
Copy link
Contributor Author

Hey folks, is it possible to backport this to current release version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants