try http for docker manifest --insecure

[davidwtf]

- What I did
fixes #1631

- How I did it
Add retry for http when https not work

- How to verify it
docker manifest push --insecure 127.0.0.1:5000/test:v1

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

Looks like this check could be done even before we connect to the registry

[thaJeztah]

Looks like there's a small bug here, and we ignore any other error?

[thaJeztah]

Perhaps reverse the logic, and do an early return; with my other suggestions;

func (c *client) getRepositoryForReference(ctx context.Context, ref reference.Named, repoEndpoint repositoryEndpoint) (distribution.Repository, error) {
	repoName, err := reference.WithName(repoEndpoint.Name())
	if err != nil {
		return nil, errors.Wrapf(err, "failed to parse repo name from %s", ref)
	}
	httpTransport, err := c.getHTTPTransportForRepoEndpoint(ctx, repoEndpoint)
	if err != nil {
		if !strings.Contains(err.Error(), "server gave HTTP response to HTTPS client") {
			return nil, err
		}
		if !repoEndpoint.endpoint.TLSConfig.InsecureSkipVerify {
			return nil, ErrHTTPProto{OrigErr: err.Error()}
		}
		// --insecure was set; fall back to plain HTTP
		if url := repoEndpoint.endpoint.URL; url != nil && url.Scheme == "https" {
			url.Scheme = "http"
			httpTransport, err = c.getHTTPTransportForRepoEndpoint(ctx, repoEndpoint)
			if err != nil {
				return nil, err
			}
		}
	}
	return distributionclient.NewRepository(repoName, repoEndpoint.BaseURL(), httpTransport)
}

[davidwtf]

Modified according to your suggestion.
Thanks.

[thaJeztah]

thanks! the changes look ok, but could you:

• squash the commits (so that there's a single commit in this PR)
• update the commit message (there's a typo, and it may be good to describe this is for the manifest commands)

let me know if you need help doing so 👍

[davidwtf]

Hi @thaJeztah,
please check again. I've squashed the commits.
Thanks.

[thaJeztah]

Whoops, thought I left my review already, but looks like I didn't submit it

LGTM

[thaJeztah]

@silvin-lubecki PTAL

[altishchenko]

Guys! Merge this Please!

[silvin-lubecki]

LGTM