Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: run CodeQL only on cron-job, not on pull requests #2770

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

thaJeztah
Copy link
Member

follow-up to #2768

Analysis takes more than 10 minutes, which is quite long to run, so change it to only run on a cron job.

Also changing the cron to run on Thursdays instead of Fridays; no need to worry about security issues during the Weekend.

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

Codecov Report

Merging #2770 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2770   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files         297      297           
  Lines       18656    18656           
=======================================
  Hits        10662    10662           
  Misses       7132     7132           
  Partials      862      862           

Analysis takes more than 10 minutes, which is quite long to
run, so change it to only run on a cron job.

Also changing the cron to run on Thursdays instead of Fridays;
no need to worry about security issues during the Weekend.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 9b92be0 into docker:master Oct 1, 2020
@thaJeztah thaJeztah deleted the codeql_cron_only branch October 1, 2020 16:36
@thaJeztah thaJeztah added this to the 20.10.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants