-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: github.com/spf13/cobra v1.1.1 #2794
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 297 297
Lines 18634 18634
=======================================
Hits 10649 10649
Misses 7126 7126
Partials 859 859 |
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 297 297
Lines 18634 18634
=======================================
Hits 10649 10649
Misses 7126 7126
Partials 859 859 |
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 297 297
Lines 18634 18634
=======================================
Hits 10649 10649
Misses 7126 7126
Partials 859 859 |
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 297 297
Lines 18634 18634
=======================================
Hits 10649 10649
Misses 7126 7126
Partials 859 859 |
We may want to wait for the discussion on spf13/cobra#1259 to settle, or skip the yaml version bump. I was doing this vendor in preparation of spf13/cobra#1255 to be merged upstream. Let me move this back to draft in the meantime |
full diff: spf13/cobra@v1.0.0...v1.1.1 Notable changes: - Extend Go completions and revamp zsh comp - Add completion for help command - Complete subcommands when TraverseChildren is set - Fix stderr printing functions - fix: fish output redirection - fix manpage building with new go-md2man Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Updated to v1.1.1 and removed the YAML bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vendor: github.com/spf13/cobra v1.1.1
full diff: spf13/cobra@v1.0.0...v1.1.1
Notable changes:
relates to / addresses docker/docker-ce-packaging#502