-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Swarm Job support to Stack Deploy #2907
Conversation
Anything blocking this from being merged? I'll admit, I don't know the process for this repo, but this not existing is blocking a project of mine. |
I'm a fan of this.
TLDR: Swarm Jobs in Stacks seems a must long term, unless jobs don't prove worthwhile as first class concepts. +1 for everyone above getting the ball rolling on this! |
@thaJeztah or @silvin-lubecki PTAL Thanks 🙏 |
This looks like a small change in code, but without yaml support jobs in Swarm are not usable. Most people who use Swarm for years emulated jobs with replicas: 0 in yaml. The overhead of converting our current hundred yaml scripts to cli style docker service update is HUGE. This one should definitely be a top priority bugfix. |
I would love to see support for this. |
Agree with you @grishin, we're holding off using jobs until it's supported in Would really appreciate if @thaJeztah or @silvin-lubecki could provide some quick feedback for this, even if it's just an ETA on when this could be reviewed properly. Thanks! |
+1 |
Any news on this? |
+1 |
Added the support for both `global-job` and `replicated-job` to Docker stack deploy. Signed-off-by: ollypom <oppomeroy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sorry, this one somehow dropped off my radar (did a quick rebase to have a fresh run of CI)
- What I did
Added the support for both
global-job
andreplicated-job
to Docker Stack deploy.Follow up to #2262.
For
replicated-jobs
, the number of replicas adjusts the number of Concurrent Tasks as well as the required number of Completed Tasks. I have not added support formax-concurrent
which allows the number of Concurrent Tasks and the number of Completed Tasks to be set independently. This is becausemax-concurrent
is currently not defined in Compose, so I believe a follow up PR is required to addmax-concurrent
once support is in Compose.- How to verify it
Locally verified with the following 3 Stack files.
- Description for the changelog
Swarm Job support in
docker stack deploy