Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup leftovers for --stream build flag #3305

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Sep 20, 2021

relates to #2809

--stream build flag is marked as removed since Docker 20.10.

- What I did

Cleanup leftovers for --stream build flag.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

cc @thaJeztah

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was considering if we needed to change thew warning to an error (slightly more informative than "unknown flag: --stream"), but I guess it's been a year that we printed this message, so probably ok to remove.

@thaJeztah
Copy link
Member

@tonistiigi @cpuguy83 ptal

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #3305 (8dec4bc) into master (3dfef76) will increase coverage by 0.38%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
+ Coverage   58.81%   59.19%   +0.38%     
==========================================
  Files         286      288       +2     
  Lines       24640    24637       -3     
==========================================
+ Hits        14491    14583      +92     
+ Misses       9265     9170      -95     
  Partials      884      884              

@crazy-max
Copy link
Member Author

@thaJeztah Rebased in case we still want this.

@cpuguy83 cpuguy83 merged commit 4011187 into docker:master Nov 9, 2022
@crazy-max crazy-max deleted the rm-stream branch November 9, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants