Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support placement preferences in stack deployment #35

Merged
merged 1 commit into from
May 9, 2017
Merged

Support placement preferences in stack deployment #35

merged 1 commit into from
May 9, 2017

Conversation

denverdino
Copy link
Contributor

Move of moby/moby#32743

Signed-off-by: Li Yi denverdino@gmail.com

@denverdino denverdino mentioned this pull request May 6, 2017
Closed
@dnephin
Copy link
Contributor

dnephin commented May 8, 2017

needs a rebase

@denverdino
Support placement preferences in stack deployment
b345993 
Move of moby/moby#32743

Signed-off-by: Li Yi <denverdino@gmail.com>
@denverdino
Copy link
Contributor Author

Rebased

dnephin
dnephin approved these changes May 9, 2017
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes May 9, 2017
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 3d58c3f into docker:master May 9, 2017
@aaronlehmann aaronlehmann mentioned this pull request May 11, 2017
Closed
@mlaventure mlaventure added this to the 17.06.0 milestone May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
impact/changelog
Projects
None yet
Milestone
17.06.0
Development

Successfully merging this pull request may close these issues.
4 participants
@denverdino @dnephin @vdemeester @mlaventure