New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --format to docker-search #440

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Projects
None yet
7 participants
@boaz1337
Contributor

boaz1337 commented Aug 15, 2017

- What I did

This is a follow-up to Jeremy's PR moby/moby#31539.

This patch adds the format flag to the docker search command and by that completes moby/moby#30431.

Signed-off-by: Jeremy Chambers jeremy@thehipbot.com
Signed-off-by: Boaz Shuster ripcurld.github@gmail.com

- How I did it

  • Created cli/command/formatter/search.go and cli/command/formatter/search_test.go
  • Updated cli/command/registry/search.go and docs/reference/commandline/search.md

- How to verify it

Run unit tests

- Description for the changelog

Add format to docker search

- A picture of a cute animal (not mandatory but encouraged)

Show outdated Hide outdated docs/reference/commandline/search.md Outdated
Show outdated Hide outdated docs/reference/commandline/search.md Outdated
Show outdated Hide outdated docs/reference/commandline/search.md Outdated
Show outdated Hide outdated docs/reference/commandline/search.md Outdated
Show outdated Hide outdated docs/reference/commandline/search.md Outdated
@vdemeester

LGTM 🐸

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 22, 2017

Codecov Report

Merging #440 into master will decrease coverage by 0.2%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   47.04%   46.84%   -0.21%     
==========================================
  Files         198      198              
  Lines       16349    16339      -10     
==========================================
- Hits         7692     7654      -38     
- Misses       8262     8295      +33     
+ Partials      395      390       -5

codecov-io commented Aug 22, 2017

Codecov Report

Merging #440 into master will decrease coverage by 0.2%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   47.04%   46.84%   -0.21%     
==========================================
  Files         198      198              
  Lines       16349    16339      -10     
==========================================
- Hits         7692     7654      -38     
- Misses       8262     8295      +33     
+ Partials      395      390       -5
@dnephin

Thanks! LGTM

some minor comments, but nothing blocking merge

Show outdated Hide outdated cli/command/registry/search.go Outdated
Show outdated Hide outdated cli/command/formatter/search.go Outdated
Show outdated Hide outdated cli/command/formatter/search_test.go Outdated
@boaz1337

This comment has been minimized.

Show comment
Hide comment
@boaz1337

boaz1337 Aug 22, 2017

Contributor

@dnephin no problemo

Contributor

boaz1337 commented Aug 22, 2017

@dnephin no problemo

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Aug 22, 2017

Collaborator

@mstanleyjones docs looks good now?

Collaborator

dnephin commented Aug 22, 2017

@mstanleyjones docs looks good now?

@mistyhacks

Approved with one teensy little suggestion for improvement. Thanks! 🙌

Show outdated Hide outdated docs/reference/commandline/search.md Outdated
@boaz1337

This comment has been minimized.

Show comment
Hide comment
@boaz1337

boaz1337 Aug 22, 2017

Contributor

@mstanleyjones done! thanks for your review 👍 🍡

Contributor

boaz1337 commented Aug 22, 2017

@mstanleyjones done! thanks for your review 👍 🍡

@mistyhacks

This comment has been minimized.

Show comment
Hide comment
@mistyhacks

mistyhacks Aug 22, 2017

Contributor

GMail renders that 🍡 as a radish!

Contributor

mistyhacks commented Aug 22, 2017

GMail renders that 🍡 as a radish!

Show outdated Hide outdated docs/reference/commandline/search.md Outdated
Add --format to docker-search
Signed-off-by: Jeremy Chambers <jeremy@thehipbot.com>
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
@boaz1337

This comment has been minimized.

Show comment
Hide comment
@boaz1337

boaz1337 Aug 22, 2017

Contributor

@mstanleyjones ☕️

Contributor

boaz1337 commented Aug 22, 2017

@mstanleyjones ☕️

@mistyhacks

🍦

@dnephin dnephin merged commit 05308fc into docker:master Aug 22, 2017

8 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 96.36% of diff hit (target 50%)
Details
codecov/project Absolute coverage decreased by -0.2% but relative coverage increased by +49.31% compared to 79ecfa8
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment