Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for docker config command family #283

Merged
merged 3 commits into from
Jul 20, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Jul 3, 2017

This adds bash completion for #45.
Ping @sdurrheimer for zsh completion

Additional commits add related functionality/refactorings:

@codecov-io
Copy link

codecov-io commented Jul 3, 2017

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #283   +/-   ##
======================================
  Coverage    48.7%   48.7%           
======================================
  Files         185     185           
  Lines       12168   12168           
======================================
  Hits         5926    5926           
  Misses       5875    5875           
  Partials      367     367

@mlaventure
Copy link
Contributor

@albers do you think it'd be possible to have path completion enabled for config create ?

i.e.:

$ docker config my-<tab>

correctly doesn't offer suggestion

but

$ docker config my-config /etc/<tab>

Doesn't either, and I would have expected it to do so.

This adds bash completion for
- docker#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
The completion logic should be implemented in the documented subcommands
(ls, rm) and delegated to from the aliases (list, remove).
For the rm|remove pair, this was implemented vice versa.

Signed-off-by: Harald Albers <github@albersweb.de>
@albers
Copy link
Collaborator Author

albers commented Jul 7, 2017

@mlaventure Nice catch, thanks a lot. I added path completion to docker config create.

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It works perfectly now, amazing job as always, really appreciated :)

LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants