-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completion for docker config
command family
#283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
======================================
Coverage 48.7% 48.7%
======================================
Files 185 185
Lines 12168 12168
======================================
Hits 5926 5926
Misses 5875 5875
Partials 367 367 |
e400b90
to
b5964ac
Compare
@albers do you think it'd be possible to have path completion enabled for i.e.:
correctly doesn't offer suggestion but
Doesn't either, and I would have expected it to do so. |
This adds bash completion for - docker#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
The completion logic should be implemented in the documented subcommands (ls, rm) and delegated to from the aliases (list, remove). For the rm|remove pair, this was implemented vice versa. Signed-off-by: Harald Albers <github@albersweb.de>
b5964ac
to
d585e55
Compare
@mlaventure Nice catch, thanks a lot. I added path completion to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It works perfectly now, amazing job as always, really appreciated :)
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦁
This adds bash completion for #45.
Ping @sdurrheimer for zsh completion
Additional commits add related functionality/refactorings:
secret inspect --pretty
(Ref: Add --pretty option to "secret inspect" and "config inspect" #88)secret rm|remove