🚧 Add support for device-code flow login (alternative 2) 🚧 #5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurazard
changed the title
This was referenced Jul 8, 2024
laurazard
force-pushed
the
auth-device-flow-store-login
branch
3 times, most recently
from
b7aaf0a
to
32eab4e
Compare
laurazard
force-pushed
the
auth-device-flow-store-login
branch
from
32eab4e
to
2a48fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Alternative to #5244 – in this one, the whole login flow is managed/initiated by the new
OAuthStorewhenGetis called. This is a lot cleaner implementation-wise, and lets us contain almost all the new code tocli/config/credentials.The downside here is that maybe
Getis doing too much, although this isn't unheard of for third-party credential helpers to do.- How I did it
- How to verify it
Login! Do things!
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)