[25.0 backport] volume/update: require 1 argument/fix panic #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 25.0 #5511 +/- ##
==========================================
+ Coverage 59.85% 59.90% +0.04%
==========================================
Files 329 329
Lines 22066 22066
==========================================
+ Hits 13208 13219 +11
+ Misses 7933 7921 -12
- Partials 925 926 +1 |
This command was declaring that it requires at least 1 argument, when it needs exactly 1 argument. This was causing the CLI to panic when the command was invoked with no argument: `docker volume update` Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit daea277) Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
cherry-pick-daea277ee839742be94e1f41d5c477f114a81273-to-25.0
branch
from
1d8f54a
to
024b3c1
Compare
thaJeztah
added
impact/changelog
status/2-code-review
area/volumes
kind/bugfix
austinvazquez
deleted the
cherry-pick-daea277ee839742be94e1f41d5c477f114a81273-to-25.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This command was declaring that it requires at least 1 argument, when it needs exactly 1 argument. This was causing the CLI to panic when the command was invoked with no argument:
docker volume update(cherry picked from commit daea277)
- How I did it
Similar to #5426, this change updates the test as Docker 26.1 CLI does not have the UX improvements which have been added to master.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)