Add --pretty option to "secret inspect" and "config inspect" #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
force-pushed
the
pretty
branch
2 times, most recently
from
c071242
to
b8b8e02
Compare
cyli
reviewed
May 16, 2017
cli/command/formatter/secret.go
Outdated
| secretCreatedHeader = "CREATED" | ||
| secretUpdatedHeader = "UPDATED" | ||
| secretInspectPrettyTemplate Format = `ID: {{.ID}} | ||
| {{- if .Name }} |
There was a problem hiding this comment.
Non-blocking: can name on secrets and configs be empty?
There was a problem hiding this comment.
No, a name is required.
There was a problem hiding this comment.
Removed the conditional
This adds a pretty template for both inspect subcommands. For configs, it's particularly useful because it's a way to expose the config payload in the CLI in a non-base64-encoded way. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
/cc @albers @sdurrheimer |
|
@thaJeztah waiting for completion to arrive here 😕 |
|
@albers yes, agreed; I'll bring it up if we can get some "movement" there |
trapier
pushed a commit
to trapier/cli
that referenced
this pull request
Sep 30, 2019
[master] sync to upstream cli master db166da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pretty template for both inspect subcommands. For configs,
it's particularly useful because it's a way to expose the config payload
in the CLI in a non-base64-encoded way.
Fixes #88
cc @dhiltgen