Fix stack marshaling for Kubernetes #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
=========================================
- Coverage 54.81% 53.2% -1.62%
=========================================
Files 245 258 +13
Lines 15832 16338 +506
=========================================
+ Hits 8679 8692 +13
- Misses 6589 7081 +492
- Partials 564 565 +1 |
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
fix-kube-stack-marshaling
branch
from
6989522
to
9b27e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix stack marshaling for Kubernetes.
- How I did it
Add missing
inlineflag to the compose config struct.- How to verify it
Try to deploy a stack against Kubernetes on Docker For Mac, it was broken.
- A picture of a cute animal (not mandatory but encouraged)