-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add extra tag builds #213
Comments
👍 I could work on this |
+1 I need this as well. I'm in a situation where I need to build image A that image B depends on in the Has anyone got this working yet? Otherwise I may also hack this up and submit a PR :) |
+1, I would use this |
What's wrong with just setting |
I can't speak for others, but for my use case the images built by fig will be pushed into a registry (after the local fig workflow is done) and re-used by other services. The default names are great locally, but not great for pushing around (and they're missing the user prefix). It's totally possible to do this outside of fig, but it would be nice to have. |
Same here. James Mills / prologic E: prologic@shortcircuit.net.au On Tue, Aug 26, 2014 at 6:55 AM, Daniel Nephin notifications@github.com
|
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…n they are built. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
+1, allow custom tags please! |
+1 |
+1 this is killer that it's not in yet. Hurts more that someone already made a PR to do this and it was closed. |
1.6.0 RC1 was just released which includes #2092. You can now include |
How would you add extra tags to a build without an extra command @dnephin ? I wish there was a tag option to the build instruction allowing me to do something like this
All of my build context would then be explicitly declared in docker-compose.yml, allowing me to consistently run a |
You can't add extra tags, but you can tag the build with a single tag by using Compose is not primarily designed for building images. The primary focus is running containers. So while Compose does provide some basic support for building an image, it's not necessarily going to be able to support many build-tag-push workflows. You might be interested in dobi (a tool I've been prototyping). It's designed specifically for these types of workflow tasks. There's an example for building and tagging images. |
Bump runc to e87436998478d222be209707503c27f6f91be
Compose isn't primarily built for building, nor pushing... but it does. You can build with The workflow is pretty common and it would be very useful from a user-experience to be able to use multiple tags, i.e. so you can do stuff like |
What would be really useful is supporting an environment variable (say,
If you run:
which would produce
|
@dkarlovi you can tag dynamically now with
but only one tag at build time. There is no way to multiply tag now. It will be possible with minor coding if docker-compose translates COMPOSE_BUILD_TAG like a tag list for example comma separated. |
I support this use case because in our project we always need two tags, "latest" and date-tagged. |
Since I was annoyed as well of not being able to define multiple tags in my |
I would love this, it would make so many things much easier. Handling |
But it should be the recommended way of building docker images as it's the only declarative way of defining all build options, that works really well with I also don't like any of the suggested solutions for that (as their mess with with the yaml file). I believe we should have something like this:
|
After 3 years, any news? |
It's been answered already. The feature as requested is just out of scope of what Compose is designed to do, and we will not be looking to implement it beyond what already exists. Thank you for your understanding. |
When there is a container A that container B depends on, in B's Dockerfile I reference it with the command
FROM myname/A
. Unfortunately fig only tags with docker_A, but I don't want to use that in my Dockerfile. Something like the following would be goodThe text was updated successfully, but these errors were encountered: