fix security opts support (seccomp and unconfined) #10110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
parseSecurityOpts
branch
from
0d17aa2
to
c4d55a0
Compare
ndeloof
changed the title
Codecov ReportBase: 75.79% // Head: 76.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10110 +/- ##
==========================================
+ Coverage 75.79% 76.98% +1.19%
==========================================
Files 2 2
Lines 252 252
==========================================
+ Hits 191 194 +3
+ Misses 53 51 -2
+ Partials 8 7 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
parseSecurityOpts
branch
from
6ffbc9d
to
ab76461
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
parseSecurityOpts
branch
from
ab76461
to
e61c967
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
glours
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
diverge from docker/cli
ParseSecurityOptsby avoiding mutation of the source sliceRelated issue
closes #9458
closes #9505
(not mandatory) A picture of a cute animal, if possible in relation to what you did
