Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup framework.go from uncessary debug logs #10116

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Dec 21, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Clean my mess, I was debugging a previous PR and forgot that auto-merge was enabled

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours self-assigned this Dec 21, 2022
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 73.01% // Head: 73.89% // Increases project coverage by +0.88% 🎉

Coverage data is based on head (adf8e75) compared to base (6c537cc).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10116      +/-   ##
==========================================
+ Coverage   73.01%   73.89%   +0.88%     
==========================================
  Files           2        2              
  Lines         289      272      -17     
==========================================
- Hits          211      201      -10     
+ Misses         65       60       -5     
+ Partials       13       11       -2     
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.15% <57.14%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours merged commit 0307c16 into docker:v2 Dec 21, 2022
@glours glours deleted the add-buildx-plugin-e2e branch January 11, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants