log: fix race on container kill #10459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
If we go to inspect a container that we got an event for and it no longer exists on the server, handle clean up without erroring out. Fixes docker#10373. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v2 #10459 +/- ##
=======================================
Coverage 59.76% 59.77%
=======================================
Files 105 105
Lines 9074 9076 +2
=======================================
+ Hits 5423 5425 +2
- Misses 3080 3081 +1
+ Partials 571 570 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix an error that could happen while streaming logs (
compose uporcompose logs -f) and a container gets killed and goes away too fast.If we go to inspect a container that we got an event for and it no longer exists on the server, handle clean up without erroring out.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
