Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync+restart action to watch attribute #11095

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 13, 2023

What I did
Add an action to watch mode which sync and then restart the service's container

Related issue
https://docker.atlassian.net/browse/ENV-335

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours force-pushed the watch-restart branch 19 times, most recently from 20cbdb3 to 15b7771 Compare October 16, 2023 13:40
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (cf3e686) 57.48% compared to head (46d3048) 57.50%.

❗ Current head 46d3048 differs from pull request most recent head 656a85e. Consider uploading reports for the commit 656a85e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11095      +/-   ##
==========================================
+ Coverage   57.48%   57.50%   +0.02%     
==========================================
  Files         129      129              
  Lines       11243    11254      +11     
==========================================
+ Hits         6463     6472       +9     
- Misses       4150     4151       +1     
- Partials      630      631       +1     
Files Coverage Δ
pkg/compose/watch.go 36.75% <9.09%> (+0.28%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glours
Copy link
Contributor Author

glours commented Oct 16, 2023

Need an new version of compose-go to be merged

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@ndeloof ndeloof enabled auto-merge (rebase) October 18, 2023 09:59
@ndeloof ndeloof merged commit 818bc3c into docker:main Oct 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants