Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --resolve-image-digests for publish to seal service images #11136

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 26, 2023

What I did
introduce --resolve-image-digests so user can seal service images by digest when publishing a compose application, comparable to docker/app

Related issue
see #11119

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team October 26, 2023 13:40
…by digest

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (dd0803d) 57.43% compared to head (610ffcb) 57.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11136      +/-   ##
==========================================
- Coverage   57.43%   57.22%   -0.21%     
==========================================
  Files         129      129              
  Lines       11285    11325      +40     
==========================================
  Hits         6481     6481              
- Misses       4174     4213      +39     
- Partials      630      631       +1     
Files Coverage Δ
pkg/api/api.go 28.84% <ø> (ø)
cmd/compose/publish.go 47.61% <55.55%> (+0.56%) ⬆️
pkg/compose/publish.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 6727908 into docker:main Nov 2, 2023
24 checks passed
@ndeloof ndeloof deleted the publish_with_digest branch November 2, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants