Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix engine version require to use healthcheck.start_interval #11360

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 17, 2024

What I did
moby API 1.44 is implemented by Docker engine v25

Related issue
fixes #10939 (review)

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, glours, milas and jhrotko and removed request for a team January 17, 2024 07:19
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3c4593f) 56.55% compared to head (1432c8d) 56.55%.

Files Patch % Lines
pkg/compose/convert.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11360   +/-   ##
=======================================
  Coverage   56.55%   56.55%           
=======================================
  Files         136      136           
  Lines       11541    11541           
=======================================
  Hits         6527     6527           
  Misses       4387     4387           
  Partials      627      627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit f414bf7 into docker:main Jan 17, 2024
26 checks passed
@ndeloof ndeloof deleted the v25 branch January 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants