Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check external network existence when swarm is enabled #11409

Merged
merged 1 commit into from Jan 29, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 25, 2024

What I did
we can't check a swarm overlay network exists until we connect a container. Asking user to declare driver: overlay is conter-intuitive and incorrect (an external resource should have no config element declared). Better ignore and wait for connect API call to (maybe) fail and report an error to user.

Related issue
fixes #11387

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8c80297) 56.54% compared to head (84796d4) 56.54%.
Report is 3 commits behind head on main.

❗ Current head 84796d4 differs from pull request most recent head da1a34a. Consider uploading reports for the commit da1a34a to get more accurate results

Files Patch % Lines
pkg/compose/create.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11409      +/-   ##
==========================================
- Coverage   56.54%   56.54%   -0.01%     
==========================================
  Files         136      136              
  Lines       11545    11542       -3     
==========================================
- Hits         6528     6526       -2     
  Misses       4390     4390              
+ Partials      627      626       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours enabled auto-merge January 29, 2024 19:00
@glours glours merged commit ac8ea08 into docker:main Jan 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Overlay network not found on worker node
2 participants