restore support for config --no-interpolate
#11556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
glours,
milas and
jhrotko
and removed request for
a team
ndeloof
force-pushed
the
config--no-interpolate
branch
3 times, most recently
from
84e3cc9
to
7081f4f
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
config--no-interpolate
branch
from
7081f4f
to
c28e2dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11556 +/- ##
==========================================
+ Coverage 58.29% 58.31% +0.01%
==========================================
Files 135 135
Lines 11555 11593 +38
==========================================
+ Hits 6736 6760 +24
- Misses 4155 4169 +14
Partials 664 664 ☔ View full report in Codecov by Sentry. |
jhrotko
reviewed
Feb 28, 2024
jhrotko
reviewed
Feb 28, 2024
ndeloof
force-pushed
the
config--no-interpolate
branch
from
0722452
to
7031ea0
Compare
jhrotko
approved these changes
Feb 28, 2024
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
config--no-interpolate
branch
from
7031ea0
to
1a6a4ba
Compare
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
implement
configusing compose-goLoadModelso we can actually skip interpolationthis PR uses a direct ref to compose-go HEAD waiting for a new release
Related issue
fixes #7964