Allow an 'extra' top-level element in config files. #4461
Conversation
This allows writers of docker-compose.yml files to factor out repeated bits of configuration to be under an 'extra' top-level key, allowing the use of yml anchors. Signed-off-by: Tommy Beadle <tbeadle@gmail.com>
Refers to change proposed in docker/compose#4461 Signed-off-by: Tommy Beadle <tbeadle@gmail.com>
|
First of all, thank you for contributing to the project! This was proposed some time ago in #2578 - now we have an actual implementation. This looks simple enough and non-intrusive. It would probably require an update in docker/docker as well. You'll need to remove the change from the 3.0 format as it is now frozen. cc @dnephin I know you were hesitant in the past about such a feature, do you have any new thoughts on this? |
|
@shin I figured it could be included in all of the formats 2.0 and greater because it's backwards compatible. What would be required to be changed in docker/docker? I didn't think any of the changes here would impact that at all. |
|
I'm fine with supporting "extra" sections, but I think something like this is more common: "patternProperties": {
"x-.+": {}
},
|
|
Since version 3 is frozen and I needed a way to share common configuration, I hacked a small workaround, which I think I could share here (I'm not sure if this is the right place but feel free to tell me where else I can share this info :)) I'm not going to elaborate on it here, since there's a readme in the repo. |
|
Closing this in favor of docker/cli#452 |
This allows writers of docker-compose.yml files to factor out repeated
bits of configuration to be under an 'extra' top-level key, allowing the
use of yml anchors.
Signed-off-by: Tommy Beadle tbeadle@gmail.com