6008 update urllib3

[venthur]

Updated urllib3 requirements to version 1.23 (the current one). Since the requests version we depend on has a hardcoded dependency on urllib3 < 1.23 but will be updated next week, I've also updated the requirement to the next version of the requests package.

Since this requests version does not exist yet, the build for this PR will fail until the new requests version is released.

Resolves #6008

[ofek]

@shin- Hello again! Does this look fine? Many of us would like to use the newest version of requests.

[GordonTheTurtle]

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "6008-update-urllib3" git@github.com:venthur/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354429472
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

[venthur]

Refreshed the patch.

[ofek]

@shin- Can you please take one last look at this?

[ofek]

@shin- Can you please take a final look?

[shin-]

@ofek This is rude, please stop. I've seen the issue. As I mentioned, we need to be careful updating requests/urllib3 because it can have unexpected side effects. For example, this new version of urllib3 drops support for Python 3.3 and prevents installation on that version, which we may not want to do yet for Compose.

Once I'm confident in the viability of the upgrade, I'll happily push the button ; until then, Compose works just fine with urllib3==1.21.1.

[ofek]

Being rude was not my intention! Often times I receive so many notifications that I miss a few and I assumed this was a similar situation. I'm sorry buddy.

This is the first I've heard of the deprecation; let me think of a compromise.

[shin-]

@ofek No harm done!

FWIW, I'm currently working on updating dependencies on the SDK end of things, including support for Python 3.7 while retaining support for 3.3; once that hurdle is clear, it'll be much easier to transition these upgrades to Compose.

[ofek]

Ah, very interesting! I'll have to test it but I think I see a way forward.

[shin-]

Closing via #6092