Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return only numbers in short version #9096

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Return only numbers in short version #9096

merged 1 commit into from
Jan 17, 2022

Conversation

guillaumerose
Copy link
Contributor

What I did

Python version of docker compose removes the v prefix in the version.

$ docker-compose version --short
1.25.5

Some projects are using this command to check the version. I think it might be good to keep the old behavior.
Example: https://github.com/openmaptiles/openmaptiles/blob/master/quickstart.sh#L84

Related issue

(not mandatory) A picture of a cute animal, if possible in relation with what you did

image

Python version of docker compose removes the v prefix in the version.

```
$ docker-compose version --short
1.25.5
```

Signed-off-by: Guillaume Rose <gurose@redhat.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants